[Release] vRP Framework


#1167

Ah - you’re unconditionally calling Citizen.Await in your proxy library, and this does not seem to check if the promise has been resolved already at wait-time, and unconditionally yields the current coroutine. This functionality was provided by a community member, and this probably was missed during code review.

Perhaps checking around that call chain should improve the performance of your proxy library, and perhaps other users of Citizen.Await.


#1168

This issue should be resolved by this commit. Performance is still not really what one would expect, now 1000 calls to getUserId take ~4 seconds but this is all CPU-locked on the main thread, leading to a main thread hitch.

I wonder if this is inefficiency in your Lua code, in the Lua scheduler code, in the Lua runtime, or in some other part of the framework… :confused:

EDIT: duh, this was a debug server build :sweat_smile: a release build does a lot more manageable 0.83s, though this still implies a single call takes 830 microseconds, which seems a bit… bad.


#1169

Thank you for your answers and for fixing the issue, I already had in mind most of the things you said, but with a lot of confusion. I couldn’t use coroutines directly, that’s the reason I used Citizen.Await in the first place. Anyway, there is a lot of intermediate design going on, so I decided to stick to the benchmark result whatever are the reasons for it being slow and just simplify everything by not calling TriggerEvent when it’s not necessary (so I’m thinking of a more straightforward approach).


#1170

What’s up guys, i want some help to change the where it says “MENU MENU” to a custom text, somone can help me with this please?

image


#1171

vrp\modules\gui.lua line 151


#1172

Thanks bro, i will check that when i get home!


#1173

Wonder if it means we can now safely get rid of tunnel communication delays in loading mode and cut 30 seconds of loading time after the connection on the newest server builds, or are those delays meant to deal with some other issues? @Imagic


#1174

It was done to deal with the player instancing issue, probably because of too much packets sent over a short period while connecting, no idea if the issue is still relevant, but you can disable it in the config files if you want to try.


#1175

Do you mean single sessions? Got to know what to look for while trying :wink:


#1177

@Imagic would be nice if u add the phone prop to the menu im currently using vrpex and everything seems to run perfectly +1


#1178

Hei! why when i edit on group.lua the server dosen’t work?


#1179

How i can create jobs?


#1180

i need help locking a car to a level so you can only drive it if you were that level and i would also like to lock blip to a job as well so you dont see them tell ur in that job so can anyone help me? im using vrpCapture i also want to add this